The finish review
What is checked on every built screen before it ships, which convention wins and what becomes of a finding.
Every built screen is reviewed for its details and its motion before it ships, by someone who did not build it. Khaeli's product pipeline holds a gate on the result: a screen ships only when its interface and its motion are both approved for its files as they stand.
What a reviewer checks
Invoices
5 invoices, £4,320.00 outstanding
| Invoice | Customer | Status | Amount |
|---|---|---|---|
| INV-2051 | Brightwater Dental | Overdue | £1,280.00 |
| INV-2050 | Kestrel Print Co | Sent | £640.00 |
| INV-2049 | Oakline Joinery | Sent | £2,400.00 |
| INV-2048 | Pennant Cycles | Paid | £915.00 |
| INV-2047 | Fernhill Bakery | Draft | £350.00 |
Words
Sentence case, a verb on every button, a count with its noun.
Keyboard
Every control takes focus, shows its ring and has a name.
Rows
Rows part on a hairline, with no stripes and no column rules.
Colour
A status is a tint and a word, never colour alone.
Type
One body role in two weights, the title one role above it.
Motion
A hovered row changes colour and nothing else moves.
import { DownloadIcon } from "@keyline-icons/react"
import { Badge } from "@/components/ui/badge"
import { Button } from "@/components/ui/button"
import { Table, TableBody, TableCell, TableHead, TableHeader, TableRow } from "@/components/ui/table"
import { Screen, ScreenBody, ScreenHeader, ScreenSidebar } from "~/components/principles/screen"
const checks = [
{ name: "Words", looksFor: "Sentence case, a verb on every button, a count with its noun." },
{ name: "Keyboard", looksFor: "Every control takes focus, shows its ring and has a name." },
{ name: "Rows", looksFor: "Rows part on a hairline, with no stripes and no column rules." },
{ name: "Colour", looksFor: "A status is a tint and a word, never colour alone." },
{ name: "Type", looksFor: "One body role in two weights, the title one role above it." },
{ name: "Motion", looksFor: "A hovered row changes colour and nothing else moves." },
]
const invoices = [
{ number: "INV-2051", customer: "Brightwater Dental", status: "Overdue", tone: "negative", amount: "£1,280.00" },
{ number: "INV-2050", customer: "Kestrel Print Co", status: "Sent", tone: "info", amount: "£640.00" },
{ number: "INV-2049", customer: "Oakline Joinery", status: "Sent", tone: "info", amount: "£2,400.00" },
{ number: "INV-2048", customer: "Pennant Cycles", status: "Paid", tone: "positive", amount: "£915.00" },
{ number: "INV-2047", customer: "Fernhill Bakery", status: "Draft", tone: "neutral", amount: "£350.00" },
] as const
const mark = (name: string) => (
<Badge aria-hidden="true" className="bg-foreground text-background tabular-nums">
{checks.findIndex((check) => check.name === name) + 1}
</Badge>
)
export default function WhatAReviewerChecks() {
return (
<>
<Screen sidebar={<ScreenSidebar current="Invoices" />}>
<ScreenHeader
title="Invoices"
tag={mark("Words")}
line="5 invoices, £4,320.00 outstanding"
actions={
<>
{mark("Keyboard")}
<Button variant="outline" size="icon" aria-label="Export invoices">
<DownloadIcon />
</Button>
<Button>Create invoice</Button>
</>
}
/>
<ScreenBody rows>
<Table aria-label="Invoices">
<TableHeader>
<TableRow>
<TableHead>
<span className="flex items-center gap-2">Invoice {mark("Rows")}</span>
</TableHead>
<TableHead>Customer</TableHead>
<TableHead>Status</TableHead>
<TableHead className="text-right">Amount</TableHead>
</TableRow>
</TableHeader>
<TableBody>
{invoices.map((invoice, row) => (
<TableRow key={invoice.number}>
<TableCell className="font-medium">{invoice.number}</TableCell>
<TableCell>
<span className="flex items-center gap-2">
{invoice.customer}
{row === 1 ? mark("Type") : null}
{row === 3 ? mark("Motion") : null}
</span>
</TableCell>
<TableCell>
<span className="flex items-center gap-2">
<Badge variant={invoice.tone}>{invoice.status}</Badge>
{row === 0 ? mark("Colour") : null}
</span>
</TableCell>
<TableCell className="text-right">{invoice.amount}</TableCell>
</TableRow>
))}
</TableBody>
</Table>
</ScreenBody>
</Screen>
<ol className="grid gap-x-8 gap-y-4 border-t border-border p-5 text-left sm:grid-cols-2">
{checks.map((check) => (
<li key={check.name} className="flex items-start gap-3">
{mark(check.name)}
<div>
<p className="font-medium">{check.name}</p>
<p className="text-muted-foreground">{check.looksFor}</p>
</div>
</li>
))}
</ol>
</>
)
}
The reviewer reads the screen in a browser, in every state it has, at each width and in each theme the product ships. The Budgets are not on the list, because a test has already counted them.
Which convention wins
Its control heights, radius ladder, type scale and motion tokens.
What this product decided, and each exception with its reason.
Every other rule, where the two above are silent.
import { Badge } from "@/components/ui/badge"
import { Item, ItemContent, ItemDescription, ItemGroup, ItemMedia, ItemSeparator, ItemTitle } from "@/components/ui/item"
const conventions = [
{
name: "The foundation",
holds: "Its control heights, radius ladder, type scale and motion tokens.",
tag: "Never a finding",
},
{ name: "The product's design.md", holds: "What this product decided, and each exception with its reason." },
{ name: "House Taste", holds: "Every other rule, where the two above are silent." },
]
export default function WhichConventionWins() {
return (
<ItemGroup role="list" aria-label="Conventions, the one that wins first" className="max-w-md gap-0">
{conventions.map(({ name, holds, tag }, index) => (
<div key={name} role="listitem">
{index > 0 ? <ItemSeparator className="my-0" /> : null}
<Item size="sm">
<ItemMedia className="w-4 text-muted-foreground tabular-nums">{index + 1}</ItemMedia>
<ItemContent>
<ItemTitle>
{name}
{tag ? <Badge variant="outline">{tag}</Badge> : null}
</ItemTitle>
<ItemDescription>{holds}</ItemDescription>
</ItemContent>
</Item>
</div>
))}
</ItemGroup>
)
}
Where two conventions differ, the earlier one holds, so a value
the foundation fixes is never a finding. A product
departs from a House Taste rule only with the reason written in its design.md.
What a finding becomes
The Invoices screen's own styles
A Registry component
A value the foundation fixes
Something only a person can judge
A correction the owner confirms as a rule
import { Badge } from "@/components/ui/badge"
import { Item, ItemActions, ItemContent, ItemDescription, ItemGroup, ItemSeparator, ItemTitle } from "@/components/ui/item"
const findings = [
{
seen: "A hand-typed ease on a row's hover",
found: "The Invoices screen's own styles",
becomes: "Fixed with a token",
tone: "positive",
},
{
seen: "A flaw inside the menu component",
found: "A Registry component",
becomes: "Reported upstream",
tone: "info",
},
{
seen: "A press scale unlike a skill's number",
found: "A value the foundation fixes",
becomes: "Not a finding",
tone: "neutral",
},
{
seen: "How the dialog feels on a phone",
found: "Something only a person can judge",
becomes: "Left for the owner",
tone: "warning",
},
{
seen: "Totals sit at the foot of every table",
found: "A correction the owner confirms as a rule",
becomes: "Written into design.md",
tone: "info",
},
] as const
export default function WhatAFindingBecomes() {
return (
<ItemGroup role="list" aria-label="Findings on the Invoices screen" className="max-w-lg gap-0">
{findings.map(({ seen, found, becomes, tone }, index) => (
<div key={seen} role="listitem">
{index > 0 ? <ItemSeparator className="my-0" /> : null}
<Item size="sm">
<ItemContent className="basis-56">
<ItemTitle>{seen}</ItemTitle>
<ItemDescription>{found}</ItemDescription>
</ItemContent>
<ItemActions>
<Badge variant={tone}>{becomes}</Badge>
</ItemActions>
</Item>
</div>
))}
</ItemGroup>
)
}
A finding in the screen's own files is fixed there, with a token wherever it names a value, and the screen is reviewed again. A finding in a Registry component is reported once and never holds the screen back.
The skills behind it
The interface is reviewed with Jakub Krehel's better-interface: accessibility,
layout, writing, typography, colour and UI on one screen. The motion is reviewed
with Emil Kowalski's remove-animations and review-animations: what stays, by
the table of verdicts, then the code that is left.